From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 17 Jul 2018 17:10:32 +0300 From: Vladimir Davydov Subject: Re: [tarantool-patches] [PATCH 1/2] Test for valid syslog configuraton Message-ID: <20180717141032.w2khpsek3n6z3s2g@esperanza> References: <20180717102508.87945-1-arkholga@tarantool.org> <20180717131349.wgidrqo6xml4i7cb@esperanza> <20180717132323.nfukmtsjzzshh3bt@esperanza> <1531836452.68220112@f406.i.mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1531836452.68220112@f406.i.mail.ru> To: Olga Arkhangelskaia Cc: tarantool-patches@freelists.org List-ID: [ Please add an extra new line after a quote when replying to an email - this improves readability ] On Tue, Jul 17, 2018 at 05:07:32PM +0300, Olga Arkhangelskaia wrote: > >Hmm, the test doesn't pass on certain distros (see travis). I guess, > >this is because they don't have syslog configured. What about wrapping > >box.cfg in pcall and checking the status? Since we just want to check > >that there's no crash, this should do. > I'll do that way. > >Or alternatively you can test > >this by setting a custom syslog destination (you have to test it anyway > >in your other patches AFAIR). > Do you mean in syslog destination series? Yes. > I had a thought about it, but did not do in v2. Will keep in mind Up to you.