From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vdavydov.dev@gmail.com>
Date: Tue, 17 Jul 2018 16:23:23 +0300
From: Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [tarantool-patches] [PATCH 1/2] Test for valid syslog
 configuraton
Message-ID: <20180717132323.nfukmtsjzzshh3bt@esperanza>
References: <20180717102508.87945-1-arkholga@tarantool.org>
 <20180717131349.wgidrqo6xml4i7cb@esperanza>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180717131349.wgidrqo6xml4i7cb@esperanza>
To: Olga Arkhangelskaia <arkholga@tarantool.org>
Cc: tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

On Tue, Jul 17, 2018 at 04:13:49PM +0300, Vladimir Davydov wrote:
> >  test/box-tap/cfg.test.lua | 8 +++++++-
> >  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> Please squash the test into the patch with the fix (`git rebase -i`)

Hmm, the test doesn't pass on certain distros (see travis). I guess,
this is because they don't have syslog configured. What about wrapping
box.cfg in pcall and checking the status? Since we just want to check
that there's no crash, this should do. Or alternatively you can test
this by setting a custom syslog destination (you have to test it anyway
in your other patches AFAIR). In this case, this particular fix doesn't
need a test case at all - it's suffices to mention that the fix is going
to be tested in the following patches.

> 
> > 
> > diff --git a/test/box-tap/cfg.test.lua b/test/box-tap/cfg.test.lua
> > index ffafdbe42..605623013 100755
> > --- a/test/box-tap/cfg.test.lua
> > +++ b/test/box-tap/cfg.test.lua
> > @@ -6,7 +6,7 @@ local socket = require('socket')
> >  local fio = require('fio')
> >  local uuid = require('uuid')
> >  local msgpack = require('msgpack')
> > -test:plan(95)
> > +test:plan(96)
> >  
> >  --------------------------------------------------------------------------------
> >  -- Invalid values
> > @@ -464,5 +464,11 @@ code = string.format(code_fmt, dir, instance_uuid, uuid.new())
> >  test:is(run_script(code), PANIC, "replicaset_uuid mismatch")
> >  fio.rmdir(dir)
> >  
> > +--
> > +-- Check syslog configuration
> > +--
> > +code = [[box.cfg{log = 'syslog:identity=tarantool'}]]
> > +test:is(run_script(code), 0, "valid log configuration is broken")
> > +
> >  test:check()
> >  os.exit(0)