From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <vdavydov.dev@gmail.com> Date: Mon, 16 Jul 2018 13:20:49 +0300 From: Vladimir Davydov <vdavydov.dev@gmail.com> Subject: Re: [tarantool-patches] [PATCH] Do not recycle a fiber if it is canceled Message-ID: <20180716102049.n5c4rrt33jpqmtye@esperanza> References: <792cd653673e62d847222fb0ec53d8a6170aa8c9.1531481944.git.georgy@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <792cd653673e62d847222fb0ec53d8a6170aa8c9.1531481944.git.georgy@tarantool.org> To: Georgy Kirichenko <georgy@tarantool.org> Cc: tarantool-patches@freelists.org List-ID: <tarantool-patches.dev.tarantool.org> On Fri, Jul 13, 2018 at 02:47:41PM +0300, Georgy Kirichenko wrote: > If a fiber pool reuses already canceled fiber then the fiber reports an > error for any next request. Now canceled fiber returns and fiber pool > creates a new one. > > Fixes #3527 > --- > Issue: https://github.com/tarantool/tarantool/3527 > Branch: > https://github.com/tarantool/tarantool/tree/gh-3527-fiber-is-cancelled-in-pool > > > src/fiber_pool.c | 6 +++--- > test/app/fiber.result | 18 ++++++++++++++++++ > test/app/fiber.test.lua | 6 ++++++ > 3 files changed, 27 insertions(+), 3 deletions(-) Looks good to me.