From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id A0ADD2706C for ; Fri, 13 Jul 2018 04:48:59 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5JyVyGhHTo6Y for ; Fri, 13 Jul 2018 04:48:59 -0400 (EDT) Received: from smtp34.i.mail.ru (smtp34.i.mail.ru [94.100.177.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 50C5C27062 for ; Fri, 13 Jul 2018 04:48:59 -0400 (EDT) Received: from [185.6.245.156] (port=16244 helo=tarantool.org) by smtp34.i.mail.ru with esmtpa (envelope-from ) id 1fdtl3-0005Dn-Mt for tarantool-patches@freelists.org; Fri, 13 Jul 2018 11:48:57 +0300 Date: Fri, 13 Jul 2018 11:48:57 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH v6 2/2] replication: force gc to clean xdir on ENOSPC err Message-ID: <20180713084857.dmr4sbqhmufj2fnz@tarantool.org> References: <9baac2b91b8a687be7dfb3e7db4aea7bc86fcb33.1531406514.git.k.belyavskiy@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9baac2b91b8a687be7dfb3e7db4aea7bc86fcb33.1531406514.git.k.belyavskiy@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Hello, On 12 июл 17:44, Konstantin Belyavskiy wrote: > Garbage collector do not delete xlog unless replica do not notify > master with newer vclock. This can lead to running out of disk > space error and this is not right behaviour since it will stop the > master. > Fix it by forcing gc to clean xlogs for replica with highest lag. > Add an error injection and a test. > > Changes in V2: > - Promoting error from wal_thread to tx via cpipe. > Changes in V3: > - Delete consumers and only for replicas (but not backup). > Changes in V4: > - Bug fix and small changes according to review. > Changes in V5: > - Compare signatures of the oldest replica and the oldest snapshot > to keep to prevent deletion if it will not free any disk space. > - Add say_crit on consumer deletion with a little information. > Changes in V6: > - Rebase to latest 1.10. > - Update test. Why did you put a ChangeLog entry to commit message? -- Regards, Kirill Yukhin