From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 5C9CD22147 for ; Wed, 11 Jul 2018 09:45:32 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Z18lKxF5qYkz for ; Wed, 11 Jul 2018 09:45:32 -0400 (EDT) Received: from smtp53.i.mail.ru (smtp53.i.mail.ru [94.100.177.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id A236920488 for ; Wed, 11 Jul 2018 09:45:31 -0400 (EDT) Date: Wed, 11 Jul 2018 16:45:27 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH v2 0/4] sql: get rid off sqlite3NestedParse Message-ID: <20180711134527.k2f5ovvob5hnaoww@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: korablev@tarantool.org, Kirill Shcherbatov Hello, On 10 июл 20:08, Kirill Shcherbatov wrote: > As we are going to implement parser as separate library, > we should get rid off sqlite3NestedParse calls. > Last usages in statistics update could be trivially rewrited > to do not start parsing. We manually build AST structures > simmilar to parser did and manually call sql_table_delete_from. > Finilly, I've removed all sqlite3NestedParse mentionings. > Also slightly refactored OP_Open{Write,Read} opcodes and > vdbe_emit_open_cursor function to use index_id instead of tnum. > > Branch: http://github.com/tarantool/tarantool/tree/kshch/gh-3496-no-nested-parse > Issue: https://github.com/tarantool/tarantool/issues/3496 I've pushed the patchset into 2.0 branch. -- Regards, Kirill Yukhin