From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 10 Jul 2018 21:57:24 +0300 From: Konstantin Osipov Subject: Re: [PATCH v2 1/4] txn: do not require space id for nop requests Message-ID: <20180710185724.GG22105@chai> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: To: Vladimir Davydov Cc: tarantool-patches@freelists.org List-ID: * Vladimir Davydov [18/07/09 18:45]: > Currently, IPROTO_NOP can only be generated by a before_replace trigger, > when it returns the old tuple thus turning the original operation into a > NOP. In such a case we know the space id and we write it to the request > body. This allows us to dispatch NOP requests via DML route. > > As a part of replica local spaces feature, we will substitute requests > operating on local spaces with NOP in relay in order to promote vclock > on replicas without actual data modification. Since space_id is stored > in request body, sending it to replicas would mean decoding the request > body in relay, which is an overkill. To avoid that, let's separate NOP > and DML paths and remove space_id from NOP requests. > I pushed this patch set. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov