From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 82024217B0 for ; Tue, 10 Jul 2018 04:10:37 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nbMh0HB7bpfN for ; Tue, 10 Jul 2018 04:10:37 -0400 (EDT) Received: from smtp56.i.mail.ru (smtp56.i.mail.ru [217.69.128.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 3778521794 for ; Tue, 10 Jul 2018 04:10:37 -0400 (EDT) From: Olga Arkhangelskaia Subject: [tarantool-patches] [PATCH] Refactoring in string validation of log parametrs Date: Tue, 10 Jul 2018 11:10:05 +0300 Message-Id: <20180710081005.88750-1-arkholga@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: Olga Arkhangelskaia Log type check happens twise. This patch deletes unnecessary check Signed-off-by: Olga Arkhangelskaia --- src/box/box.cc | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/box/box.cc b/src/box/box.cc index 033829a7f..464018f35 100644 --- a/src/box/box.cc +++ b/src/box/box.cc @@ -342,11 +342,6 @@ box_check_say() diag_last_error(diag_get())->errmsg); } - if (say_check_init_str(log) == -1) { - - diag_raise(); - } - if (type == SAY_LOGGER_SYSLOG) { struct say_syslog_opts opts; if (say_parse_syslog_opts(log, &opts) < 0) { -- 2.14.3 (Apple Git-98)