From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 071D624C00 for ; Mon, 9 Jul 2018 11:35:31 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NvSf9Vf1u1V6 for ; Mon, 9 Jul 2018 11:35:30 -0400 (EDT) Received: from smtp5.mail.ru (smtp5.mail.ru [94.100.179.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id B78B424BC5 for ; Mon, 9 Jul 2018 11:35:30 -0400 (EDT) Date: Mon, 9 Jul 2018 18:35:31 +0300 From: Alexander Turenko Subject: [tarantool-patches] Re: [PATCH] sql: Remove 'BEGIN TRANSACTION' Message-ID: <20180709153406.rhnb4wstnrwkphtk@tkn_work_nb> References: <1530787337-18302-1-git-send-email-hollow653@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1530787337-18302-1-git-send-email-hollow653@gmail.com> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Nikita Tatunov Cc: tarantool-patches@freelists.org, Nikita Pettik Hi Nikita! I don't have objections against the patch, just two comments re tests. It would be good to check a table content in the test to make sure a transaction was executed as expected. The new test failed in CI: https://travis-ci.org/tarantool/tarantool/jobs/400390677 https://travis-ci.org/tarantool/tarantool/jobs/400390678 Please, ask next review from Nikita P. WBR, Alexander Turenko. On Thu, Jul 05, 2018 at 01:42:17PM +0300, N.Tatunov wrote: > Patch is aimed on making our sql closer to ANSI sql. > > With the patch applied only following commands can be used: > - "START TRANSACTION" to begin transaction. > - "COMMIT" to end transaction. > - "ROLLBACK" to rollback transaction without savepoints. > - "ROLLBACK TO .." to rollback transaction to savepoint. > > Closes #2164 > --- > > Issue: https://github.com/tarantool/tarantool/issues/2164 > Branch: https://github.com/tarantool/tarantool/tree/N_Tatunov/gh-2164-remove-begin-transaction >