From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 7F5FA26B9C for ; Fri, 6 Jul 2018 10:29:09 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UoAeLe1U2hVq for ; Fri, 6 Jul 2018 10:29:09 -0400 (EDT) Received: from smtp39.i.mail.ru (smtp39.i.mail.ru [94.100.177.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 369B226AF4 for ; Fri, 6 Jul 2018 10:29:09 -0400 (EDT) Date: Fri, 6 Jul 2018 17:29:06 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH] Do not update schema_version on space:truncate(). Message-ID: <20180706142906.GA10648@chai> References: <20180706114625.10152-1-sergepetrenko@tarantool.org> <20180706140754.GA3514@chai> <7de60a16-1273-6c1b-12d5-8e05ef1e3ff2@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7de60a16-1273-6c1b-12d5-8e05ef1e3ff2@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Sergey Petrenko Cc: tarantool-patches@freelists.org * Sergey Petrenko [18/07/06 17:27]: > Will fix. I thought it'd be a good idea to only increment when we already > know > we won't be returning to the old state. > So I should increase schema_version in UpdateSchemaVersion::alter() and > decrease it in > UpdateSchemaVersion::rollback() ? Never decrement. Reloading a schema extra time won't break anything. And what about creation/drop of a space? > Move > schema_version increment to on_replace_dd_space() OK. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov