From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kostja@tarantool.org>
Date: Thu, 5 Jul 2018 09:49:00 +0300
From: Konstantin Osipov <kostja@tarantool.org>
Subject: Re: [PATCH v2 1/6] xlog: store prev vclock in xlog header
Message-ID: <20180705064900.GA11571@chai>
References: <cover.1530287767.git.vdavydov.dev@gmail.com>
 <25eb188a0085216aef3a2e292fe14d0df71ede13.1530287767.git.vdavydov.dev@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <25eb188a0085216aef3a2e292fe14d0df71ede13.1530287767.git.vdavydov.dev@gmail.com>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

* Vladimir Davydov <vdavydov.dev@gmail.com> [18/06/29 19:49]:
> This patch adds a new key to xlog header, PrevVclock, which contains the
> vclock of the previous xlog file in the xlog directory. It is set by
> xdir_create_xlog() to the last vclock in xdir::index. The new key is
> only present in XLOG files (it doesn't make sense for SNAP or VYLOG
> anyway). It will be used to make the check for xlog gaps more thorough.

I don't like has_prev_vclock. 

I don't know what to do with it yet. Ideally, I would make it xdir
property - and set it on for xlog dir.

I'm not sure it's feasible, looking.

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov