From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vdavydov.dev@gmail.com>
Date: Wed, 4 Jul 2018 17:23:46 +0300
From: Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [PATCH v2] box: allow vinyl_memory set to 0 in config
Message-ID: <20180704142346.6zwmshrzdi2xf7r3@esperanza>
References: <20180704132348.74595-1-sergepetrenko@tarantool.org>
 <20180704133735.2eplki6u4ndkekzr@esperanza>
 <d9ae2a64-4ab3-e376-ef30-c7c96c0788bf@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <d9ae2a64-4ab3-e376-ef30-c7c96c0788bf@tarantool.org>
To: Sergey Petrenko <sergepetrenko@tarantool.org>
Cc: tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

On Wed, Jul 04, 2018 at 05:11:10PM +0300, Sergey Petrenko wrote:
> diff --git a/test/box-tap/cfg.test.lua b/test/box-tap/cfg.test.lua
> index b93a21f35..5608f6578 100755
> --- a/test/box-tap/cfg.test.lua
> +++ b/test/box-tap/cfg.test.lua
> @@ -6,7 +6,7 @@ local socket =3D require('socket')
> =A0local fio =3D require('fio')
> =A0local uuid =3D require('uuid')
> =A0local msgpack =3D require('msgpack')
> -test:plan(91)
> +test:plan(92)
>=20
> =A0----------------------------------------------------------------------=
----------
> =A0-- Invalid values
> @@ -164,6 +164,13 @@ function run_script(code)
> =A0=A0=A0=A0 return res
> =A0end
>=20
> +-- gh-3468: should allow box.cfg with vinyl_memory=3D0
> +code =3D[[
> +box.cfg{vinyl_memory=3D0}
> +os.exit(box.cfg.vinyl_memory =3D=3D 0 and 0 or 1)
> +]]
> +test:is(run_script(code), 0, "actually set vinyl_memory to 0")

Looks good to me.