From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vdavydov.dev@gmail.com>
Date: Wed, 4 Jul 2018 15:02:38 +0300
From: Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [tarantool-patches] [PATCH] box: allow vinyl_memory set to 0 in
 config
Message-ID: <20180704120237.4zfmw3pzm24cdblk@esperanza>
References: <20180704113634.71324-1-sergepetrenko@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180704113634.71324-1-sergepetrenko@tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

On Wed, Jul 04, 2018 at 02:36:34PM +0300, Serge Petrenko wrote:
> In 1.9 it was possible to have a vinylless configuration with
> vinyl_memory=0, allow to do this in 1.10 by adjusting sanity
> checks for vinyl_memory and memtx_memory. Now banning only
> negative values.
> memtx_memory check was changed for consistency, trying to
> set memtx_memory to 0 fails anyways.
> 
> Closes: #3468
> ---
> https://github.com/tarantool/tarantool/compare/sergepetrenko/gh-3468-allow-0-vinyl-memory
> https://github.com/tarantool/tarantool/issues/3468
> 
> src/box/box.cc      | 8 ++++----
>  test/box/cfg.result | 4 ++--
>  2 files changed, 6 insertions(+), 6 deletions(-)

Please add a test case checking that box.cfg.vinyl_memory can actually
be set to 0. Other than that looks OK.