From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 5368626429 for ; Wed, 4 Jul 2018 06:46:13 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oqT9oFWlA0Oe for ; Wed, 4 Jul 2018 06:46:13 -0400 (EDT) Received: from smtp56.i.mail.ru (smtp56.i.mail.ru [217.69.128.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 1178B24E44 for ; Wed, 4 Jul 2018 06:46:12 -0400 (EDT) Date: Wed, 4 Jul 2018 13:46:11 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH v9] sql: add index_def to struct Index Message-ID: <20180704104611.uwgbg4bayrvzuuzg@tarantool.org> References: <9A0A687D-2E0B-4AB9-B223-1A1287817824@tarantool.org> <8900ae2a-59e8-d69a-7f5d-95436b23214a@tarantool.org> <0e795fb5-1ee8-e7e6-65e4-7347787f3248@tarantool.org> <898ec1ac-51b9-13a6-6298-3a20eeac5b2b@tarantool.org> <76c1ec30-4f33-bc91-8845-72a99fc4ef0f@tarantool.org> <6fbc3849-a204-6cd9-82cd-2fb22769ccf0@tarantool.org> <2d4908aa-0243-8dc3-e109-707cb482b7f6@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2d4908aa-0243-8dc3-e109-707cb482b7f6@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: Vladislav Shpilevoy Hello, On 03 июл 14:37, Ivan Koptelov wrote: > In previous patch versions I didn't fix one test, which prints all error > codes. > At failed, because I added new error code. Now the test is fixed. > > > Now every sqlite struct Index is created with tnt struct > > > index_def inside. This allows us to use tnt index_def > > > in work with sqlite indexes in the same manner as with > > > tnt index and is a step to remove sqlite Index with > > > tnt index. > > > Fields coll_array, coll_id_array, aiColumn, sort_order > > > and zName are removed from Index. All usages of this > > > fields changed to usage of corresponding index_def > > > fields. > > > index_is_unique(), sql_index_collation() and > > > index_column_count() are removed with calls of > > > index_def corresponding fields. > > > > > > Closes: #3369 > > > > > > --- > > > Branch: > > > https://github.com/tarantool/tarantool/tree/sb/gh-3369-use-index-def-in-select-and-where > > > > > > Issue:https://github.com/tarantool/tarantool/issues/3369 I've checked the patch into 2.0 branch. -- Regards, Kirill Yukhin