From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 3 Jul 2018 20:10:34 +0300 From: Konstantin Osipov Subject: Re: [tarantool-patches] Re: [PATCH v1 1/1] lib/bitset: rename bitset structs Message-ID: <20180703171034.GA13606@chai> References: <20180703103753.o3isk2wymm73ab6f@esperanza> <2a09bc5d-8b80-d387-7ff2-2ccb4b14d2d8@tarantool.org> <20180703125241.nqmufiqi56s4dqnv@esperanza> <20180703162556.hdoovac2e3nnd3t2@esperanza> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180703162556.hdoovac2e3nnd3t2@esperanza> To: Vladimir Davydov Cc: Kirill Shcherbatov , tarantool-patches@freelists.org List-ID: * Vladimir Davydov [18/07/03 19:29]: > On Tue, Jul 03, 2018 at 04:24:36PM +0300, Kirill Shcherbatov wrote: > > > I don't think you should rename any structures or functions defined in > > > memtx_bitset.c - they don't conflict and they are not related to struct > > > bitset. > > > > Changes in memtx_bitset.{c, h} with my patch now. > > Technically, the patch looks fine to me. Kostja, does renaming struct > bitset to tt_bitset in order to fix FreeBSD build make sense to you, > or you have a better idea in mind? No, I haven't. We can rename again when we get a better idea. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov