From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vdavydov.dev@gmail.com>
Date: Tue, 3 Jul 2018 19:25:56 +0300
From: Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [tarantool-patches] Re: [PATCH v1 1/1] lib/bitset: rename bitset
 structs
Message-ID: <20180703162556.hdoovac2e3nnd3t2@esperanza>
References: <ebcdfd94e9e51421141c05b8b4935631bc6ae8cb.1530613570.git.kshcherbatov@tarantool.org>
 <20180703103753.o3isk2wymm73ab6f@esperanza>
 <2a09bc5d-8b80-d387-7ff2-2ccb4b14d2d8@tarantool.org>
 <20180703125241.nqmufiqi56s4dqnv@esperanza>
 <da388eae-f592-006f-0cdd-72fbbc8e1039@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <da388eae-f592-006f-0cdd-72fbbc8e1039@tarantool.org>
To: Konstantin Osipov <kostja@tarantool.org>
Cc: Kirill Shcherbatov <kshcherbatov@tarantool.org>, tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

On Tue, Jul 03, 2018 at 04:24:36PM +0300, Kirill Shcherbatov wrote:
> > I don't think you should rename any structures or functions defined in
> > memtx_bitset.c - they don't conflict and they are not related to struct
> > bitset.
> 
> Changes in memtx_bitset.{c, h} with my patch now.

Technically, the patch looks fine to me. Kostja, does renaming struct
bitset to tt_bitset in order to fix FreeBSD build make sense to you,
or you have a better idea in mind?