From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 4D25F26FA6 for ; Tue, 3 Jul 2018 09:03:54 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IvB-i5axRzfz for ; Tue, 3 Jul 2018 09:03:54 -0400 (EDT) Received: from smtp37.i.mail.ru (smtp37.i.mail.ru [94.100.177.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 0314E26F9E for ; Tue, 3 Jul 2018 09:03:53 -0400 (EDT) Received: by smtp37.i.mail.ru with esmtpa (envelope-from ) id 1faKyF-0005b1-Lz for tarantool-patches@freelists.org; Tue, 03 Jul 2018 16:03:52 +0300 From: Konstantin Belyavskiy Subject: [tarantool-patches] [PATCH v4 0/2] force gc on running out of disk space Date: Tue, 3 Jul 2018 16:03:45 +0300 Message-Id: <20180703130347.26296-1-k.belyavskiy@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Garbage collector do not delete xlog unless replica do not notify master with newer vclock. This can lead to running out of disk space error and this is not right behaviour since it will stop the master. Fix it by forcing gc to clean xlogs for replica with highest lag. Add an error injection and a test. Split between two different commits to improve readability. First is a proposal to separate tx_prio thread from tx since they behave differently (the first does not support yield call). Second is actually a proposal to use messages from wall thread to tx thread to notify gc to do not keep logs for the oldest replica. Changes in V2: - Promoting error from wal_thread to tx via cpipe. Changes in V3: - Delete consumers and only for replicas (but not backup). Changes in V4: - Bug fix and small changes according to review. Tichet: https://github.com/tarantool/tarantool/issues/3397 Branch: kbelyavs/gh-3397-force-del-logs-on-no-disk-space Konstantin Belyavskiy (2): replication: rename thread from tx to tx_prio replication: force gc to clean xdir on ENOSPC err src/box/box.cc | 1 + src/box/gc.c | 49 +++++++++ src/box/gc.h | 16 +++ src/box/relay.cc | 1 + src/box/wal.cc | 44 ++++++-- src/errinj.h | 1 + src/fio.c | 7 ++ test/box/errinj.result | 2 + test/replication/kick_dead_replica_on_enspc.result | 121 +++++++++++++++++++++ .../kick_dead_replica_on_enspc.test.lua | 56 ++++++++++ test/replication/suite.ini | 2 +- 11 files changed, 291 insertions(+), 9 deletions(-) create mode 100644 test/replication/kick_dead_replica_on_enspc.result create mode 100644 test/replication/kick_dead_replica_on_enspc.test.lua -- 2.14.3 (Apple Git-98)