From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id C8F4C26904 for ; Fri, 29 Jun 2018 09:54:31 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lOEvE0U-FnoJ for ; Fri, 29 Jun 2018 09:54:31 -0400 (EDT) Received: from smtp56.i.mail.ru (smtp56.i.mail.ru [217.69.128.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 76A5926883 for ; Fri, 29 Jun 2018 09:54:31 -0400 (EDT) Date: Fri, 29 Jun 2018 16:54:25 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH v4 8/8] sql: remove global sql_trigger hash Message-ID: <20180629135425.lvctpxgae7dnmzbl@tarantool.org> References: <81986d1f9307191bd3d3e37514dc32fadb7e6970.1530029141.git.kshcherbatov@tarantool.org> <1d6bcf87b16c4b7c64eb82d3da43adfabede0a7e.1530029141.git.kshcherbatov@tarantool.org> <44395AB5-7067-46A9-A785-A0707686DCD9@tarantool.org> <02c40c29-8dec-d4dd-c645-216e14bdd5f9@tarantool.org> <3e413ef3-4c4f-0337-32eb-b7d901248e9e@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Vladislav Shpilevoy Cc: Kirill Shcherbatov , tarantool-patches@freelists.org, Nikita Pettik On 29 июн 16:31, Vladislav Shpilevoy wrote: > > > On 29/06/2018 16:28, Kirill Shcherbatov wrote: > > > Hello. Thanks for the patch! I have pushed my review fixes > > > as a separate commit for this patch and for > > > "sql: refactor trigger API functions". > > Hello! Thank you for fixes! > > I've spitted them and merged into appropriate commits. > > Then LGTM. Now I think it is time to merge the whole > triggers patchset. I've checked the patchset in 2.0 branch. -- Regards, Kirill Yukhin