From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id A90F3266BF
	for <tarantool-patches@freelists.org>; Fri, 29 Jun 2018 06:21:49 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id fFgWmdHCl-WC for <tarantool-patches@freelists.org>;
	Fri, 29 Jun 2018 06:21:49 -0400 (EDT)
Received: from smtp38.i.mail.ru (smtp38.i.mail.ru [94.100.177.98])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id DDAD0266CC
	for <tarantool-patches@freelists.org>; Fri, 29 Jun 2018 06:21:48 -0400 (EDT)
Date: Fri, 29 Jun 2018 13:21:46 +0300
From: Kirill Yukhin <kyukhin@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH] sql: remove sqlite_ functions from
 SQL
Message-ID: <20180629102146.smgz3uqxiyer4oax@tarantool.org>
References: <bc5989f28ac98fbae1a22172915d49f2c9cb5def.1530020544.git.kyukhin@tarantool.org>
 <D7CF54A0-A769-4DA9-999D-A26398A2FDEE@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <D7CF54A0-A769-4DA9-999D-A26398A2FDEE@tarantool.org>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: "n.pettik" <korablev@tarantool.org>
Cc: tarantool-patches@freelists.org

Hello Nikita,
On 26 июн 18:17, n.pettik wrote:
> 
> > On 26 Jun 2018, at 16:33, Kirill Yukhin <kyukhin@tarantool.org> wrote:
> > 
> > Branch: https://github.com/tarantool/tarantool/tree/kyukhin/gh-2184-remove-version
> > Issue: https://github.com/tarantool/tarantool/issues/2184
> > 
> > Removed legacy functions: sqlite_version, sqlite_sourceid,
> > sqlite_log. Added version built-in function which returns
> > Tarantool's version.
> > 
> > Closes #2184
> > —
> 
> Please, put links to the branch and issue here (after ‘- - -‘).
Forgot about that, thanks!

> Also, I have found one mention of sqlite_version():
> 
> File: resolve.c, line: 709
Thanks I've fixed that.

Patch merged into 2.0.

--
Thanks, Kirill Yukhin