From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 28 Jun 2018 18:45:54 +0300 From: Vladimir Davydov Subject: Re: [tarantool-patches] [PATCH v3] replication: remove old snapshot files not needed by replicas Message-ID: <20180628154554.7npi3lrxkwpwadci@esperanza> References: <20180628154120.87155-1-sergepetrenko@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180628154120.87155-1-sergepetrenko@tarantool.org> To: Konstantin Osipov Cc: Serge Petrenko , tarantool-patches@freelists.org List-ID: On Thu, Jun 28, 2018 at 06:41:20PM +0300, Serge Petrenko wrote: > Garbage collection doesn't distinguish consumers which need checkpoint > files, such as backup, and the ones, who only need WALS, such as > replicas. A disconnected replica will 'hold' all checkpoint files, created > after it got unsynchronised, even though it doesn't need them, which may > lead to disk space shortage. To fix this, we store consumer's type, and > treat consumers differently during garbage collection: now only the old > WALS are stored for replicas, and old checkpoints are stored for backup, > if any. Also changed the tests to check updated garbage collection correctly. > > Closes #3444 > --- > https://github.com/tarantool/tarantool/tree/sergepetrenko/gh-3444-remove-old-shapshots-for-replicas > https://github.com/tarantool/tarantool/issues/3444 Looks good to me. Kostja, please take a look.