From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 27 Jun 2018 21:27:06 +0300 From: Konstantin Osipov Subject: Re: [PATCH 6/6] Introduce replica local spaces Message-ID: <20180627182706.GL28358@chai> References: <22474f0135864e15bb4aa2aed19662b7911aa225.1528906027.git.vdavydov.dev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <22474f0135864e15bb4aa2aed19662b7911aa225.1528906027.git.vdavydov.dev@gmail.com> To: Vladimir Davydov Cc: tarantool-patches@freelists.org List-ID: * Vladimir Davydov [18/06/13 20:40]: > @@ -48,6 +48,11 @@ struct space_opts { > * - changes are not part of a snapshot > */ > bool temporary; > + /** > + * The space is replica local: changes > + * done to it are not replicated. > + */ > + bool local; Argh, I hate this violation of the coding style. There is bool view in 2.0. Please make these flags bits to save space and prefix them all with is_ once and for all. Finally, the patch should contain a petition to @docbot so that there is a documentation request for it -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov