From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 27 Jun 2018 20:48:58 +0300 From: Konstantin Osipov Subject: Re: [PATCH 3/6] iproto: fix IPROTO_SERVER_IS_RO key code Message-ID: <20180627174858.GI28358@chai> References: <23a6cf92394dd7f5b8d32e5bfd548897ae0ead92.1528906027.git.vdavydov.dev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <23a6cf92394dd7f5b8d32e5bfd548897ae0ead92.1528906027.git.vdavydov.dev@gmail.com> To: Vladimir Davydov Cc: tarantool-patches@freelists.org List-ID: * Vladimir Davydov [18/06/13 20:40]: > IPROTO_SERVER_IS_RO currently has code 0x07 and is defined in the header > key section, which is wrong, because this key is only used in request > body. Let's move it to the body section, where it belongs, and set its > code to 0x29. This shouldn't break anything even if 0x07 is reused in > future, because the two codes belong to different sections and hence are > never parsed in the same function. Worst that can happen is we fail to > bootstrap a node in the cluster if it is running a newer tarantool > version. Ugh, this is going to break things and we may have to revert, I pushed to see how it goes. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov