From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kostja@tarantool.org>
Date: Wed, 27 Jun 2018 20:29:53 +0300
From: Konstantin Osipov <kostja@tarantool.org>
Subject: Re: [PATCH 2/6] xrow: fix ret code on decode failure
Message-ID: <20180627172953.GG28358@chai>
References: <cover.1528906027.git.vdavydov.dev@gmail.com>
 <729e7394915597be33b8d4157d6e52e8b990520d.1528906027.git.vdavydov.dev@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <729e7394915597be33b8d4157d6e52e8b990520d.1528906027.git.vdavydov.dev@gmail.com>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

* Vladimir Davydov <vdavydov.dev@gmail.com> [18/06/13 20:40]:
> Throughout the code, we return -1 on error, but decode methods return 1
> for some reason, although according to comments they are supposed to
> return -1. This doesn't result in any errors, because we use != 0 to
> check for errors. Nevertheless, let's fix it to avoid confusion.
> ---
>  src/box/xrow.c | 22 +++++++++++-----------
>  1 file changed, 11 insertions(+), 11 deletions(-)

Will push shortly.


-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov