From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 27 Jun 2018 19:02:51 +0300 From: Konstantin Osipov Subject: Re: [PATCH] vinyl: fix read iterator skips source after reading cache Message-ID: <20180627160251.GB28358@chai> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: To: Vladimir Davydov Cc: tarantool-patches@freelists.org List-ID: * Vladimir Davydov [18/06/23 08:30]: > If a source is used on a read iteration (i.e. the key at which it is > positioned is the next best match or, in terms of the read iterator > implementation, its front_id matches the read iterator front_id), its > history is cleaned up, see vy_read_iterator_apply_history(). This breaks > the logic behind vy_read_src_is_behind(), which assumes that the history > always points to the last used key. As a result, a source may be > mistakenly skipped, as illustrated below: Pushed. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov