From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 8A72D2541C for ; Sun, 17 Jun 2018 16:06:33 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0CoXmD_mPFjw for ; Sun, 17 Jun 2018 16:06:33 -0400 (EDT) Received: from smtp59.i.mail.ru (smtp59.i.mail.ru [217.69.128.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 38BA42531A for ; Sun, 17 Jun 2018 16:06:33 -0400 (EDT) Date: Sun, 17 Jun 2018 23:06:30 +0300 From: Alexander Turenko Subject: [tarantool-patches] Re: [PATCH v1] sql: change of PRAGMA INDEX_INFO syntax Message-ID: <20180617200630.azv3joe77q5nescj@tkn_work_nb> References: <1528795940-13564-1-git-send-email-vanyail@yandex.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1528795940-13564-1-git-send-email-vanyail@yandex.ru> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Ivan Ilyin Cc: tarantool-patches@freelists.org Hi Ivan! See my comments below. WBR, Alexander Turenko. On Tue, Jun 12, 2018 at 12:32:20PM +0300, Ivan Ilyin wrote: > This change removes 'pragma index_xinfo' syntax. 'pragma index_info' > now works as 'pragma index_xinfo' and also displays type of columns in > index. > > Fixes #3194 > --- Don't forget to include branch name in the message to tarantool-patches@. TARGET=test job fails in CI for your branch: see [1]. It fails before sql-tap suite and the fail does not related to your changes. But it is your responsibility to check whether the fail is flaky (restarting this job should make it green) and bring it into focus of your mentor if the fail is persistent. [1]: https://travis-ci.org/tarantool/tarantool/jobs/391176317 > diff --git a/src/box/sql/pragma.c b/src/box/sql/pragma.c > index 9dab5a7..ec0dff3 100644 > --- a/src/box/sql/pragma.c > +++ b/src/box/sql/pragma.c > <...> > + const char *c_n; > + uint32_t id; > + struct coll *coll = > + sql_index_collation(pIdx, i, &id); > + if (coll != NULL) > + c_n = coll_by_id(id)->name; > + else > + c_n = "BINARY"; > + enum sort_order sort_order; > + sort_order = sql_index_column_sort_order(pIdx, > + i); > + enum field_type type = pIdx->pTable-> > + def->fields[cnum].type; > + sqlite3VdbeMultiLoad(v, 1, "iisisis", i, > + cnum, cnum < 0 ? 0 : > + pIdx->pTable->def-> > + fields[cnum].name, > + sort_order, c_n, i < mx, > + field_type_strs[type]); Tab width is 8 symbols, please fix indent.