From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 14 Jun 2018 15:59:48 +0300 From: Konstantin Osipov Subject: Re: [PATCH v2 05/11] box: connect to remote peers before starting local recovery Message-ID: <20180614125948.GE959@chai> References: <20180613204545.GB10632@chai> <20180614083425.ozif2uoj6bmexguc@esperanza> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180614083425.ozif2uoj6bmexguc@esperanza> To: Vladimir Davydov Cc: tarantool-patches@freelists.org List-ID: * Vladimir Davydov [18/06/14 11:38]: > On Wed, Jun 13, 2018 at 11:45:45PM +0300, Konstantin Osipov wrote: > > * Vladimir Davydov [18/06/08 20:38]: > > > box_sync_replication() can now be called before recovery, right after > > > box_listen(). This is a step toward detecting if the instance fell too > > > much behind its peers in the cluster and so needs to be rebootstrapped. > > > > Shouldn't you move setting of the orphan status to someplace > > before box_sync_replication()? > > I don't think it's necessary - the instance is in 'loading' state at > that time, because it hasn't read xlogs yet. Let's think of 'orphan' > state as 'recovery complete, but the instance is still syncing'? OK, I see. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov