From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vdavydov.dev@gmail.com>
Date: Thu, 14 Jun 2018 11:34:25 +0300
From: Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [PATCH v2 05/11] box: connect to remote peers before starting
 local recovery
Message-ID: <20180614083425.ozif2uoj6bmexguc@esperanza>
References: <cover.1528478913.git.vdavydov.dev@gmail.com>
 <d4c66453c686c67622952412e61283a01d6b3535.1528478913.git.vdavydov.dev@gmail.com>
 <20180613204545.GB10632@chai>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180613204545.GB10632@chai>
To: Konstantin Osipov <kostja@tarantool.org>
Cc: tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

On Wed, Jun 13, 2018 at 11:45:45PM +0300, Konstantin Osipov wrote:
> * Vladimir Davydov <vdavydov.dev@gmail.com> [18/06/08 20:38]:
> > box_sync_replication() can now be called before recovery, right after
> > box_listen(). This is a step toward detecting if the instance fell too
> > much behind its peers in the cluster and so needs to be rebootstrapped.
> 
> Shouldn't you move setting of the orphan status to someplace
> before box_sync_replication()?

I don't think it's necessary - the instance is in 'loading' state at
that time, because it hasn't read xlogs yet. Let's think of 'orphan'
state as 'recovery complete, but the instance is still syncing'?