From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 14 Jun 2018 11:21:07 +0300 From: Vladimir Davydov Subject: Re: [PATCH] test: fix vinyl/upgrade/fill.lua script Message-ID: <20180614082107.w5pm6fqfdxabpuer@esperanza> References: <456b1a8ffd68ee945a20bd233f61a80f402a8953.1528882963.git.vdavydov.dev@gmail.com> <20180613173912.GA5404@chai> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180613173912.GA5404@chai> To: Konstantin Osipov Cc: tarantool-patches@freelists.org List-ID: On Wed, Jun 13, 2018 at 08:39:12PM +0300, Konstantin Osipov wrote: > * Vladimir Davydov [18/06/13 13:42]: > > Since commit 8f63d5d90 ("vinyl: fail transaction immediately if it does > > not fit in memory"), vinyl won't trigger memory dump if the size of > > memory needed by a transaction is greater than the memory limit, instead > > it will fail the transaction immediately. This broke the aforementioned > > script, which relied on this to trigger system-wide memory dump. Fix it > > by reworking the dump trigger logic used by the script: now it tries to > > insert two tuples, box.cfg.vinyl_memory / 2 size each, instead of one. > > > > Closes #3449 > > > > while box.stat.vinyl().quota.used > 0 do > > fiber.sleep(0.1) > > Let's settle on 0.01 as standard fiber-loop-wait time in tests. > > Otherwise it's ok to push. Fixed and pushed to 1.10