From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id B981D25834 for ; Wed, 13 Jun 2018 17:13:28 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id na13VZS2_dHT for ; Wed, 13 Jun 2018 17:13:28 -0400 (EDT) Received: from smtp21.mail.ru (smtp21.mail.ru [94.100.179.250]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 6351725803 for ; Wed, 13 Jun 2018 17:13:28 -0400 (EDT) Date: Thu, 14 Jun 2018 00:13:26 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 2/2] session: fix box.session.sync() Message-ID: <20180613211326.GI10632@chai> References: <5bba142da513a6224262993a473b57f54e0c8bc3.1528566238.git.v.shpilevoy@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5bba142da513a6224262993a473b57f54e0c8bc3.1528566238.git.v.shpilevoy@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Vladislav Shpilevoy Cc: tarantool-patches@freelists.org * Vladislav Shpilevoy [18/06/09 22:33]: > Before the patch box.session.sync() is global for the session and > is updated on each new iproto request. When the connection is > multiplexed, box.session.sync() can be changed with no finishing > a current request, if a new one arrives. > > The patch makes box.session.push() local for the request, > protecting it from multiplexing mess. Box.session.sync() after > the patch can be safely used inside a request. > > Closes #3450 OK to push. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov