From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id D6DDE255C8 for ; Wed, 13 Jun 2018 17:11:52 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vHNriZTHg5fv for ; Wed, 13 Jun 2018 17:11:52 -0400 (EDT) Received: from smtp50.i.mail.ru (smtp50.i.mail.ru [94.100.177.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 9019F2559F for ; Wed, 13 Jun 2018 17:11:52 -0400 (EDT) Date: Thu, 14 Jun 2018 00:11:50 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 1/2] fiber: remove fiber local storage Message-ID: <20180613211150.GH10632@chai> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Vladislav Shpilevoy Cc: tarantool-patches@freelists.org * Vladislav Shpilevoy [18/06/09 22:33]: > Replace it with more specific structures and pointers in order to > prepare to add `net` storage. > > This allows to make the code working with fiber storage simpler, > remove useless wrappers and casts, and in the next patch - remove > broken session.sync and add fiber sync. Please write a comment stating that under no circumstances fiber.h is allowed to include application-specific headers, one only is allowed to add opaque pointers to the storage struct. I actually thought that you're going to make it more general, adopting a concept similar to Lua stack. Anyway, the simpler the better, we can make it more general when we need it, it's OK to push. > --- > src/box/session.cc | 4 +-- > src/box/session.h | 14 ++++------ > src/box/txn.c | 2 +- > src/box/txn.h | 2 +- > src/fiber.c | 9 ++---- > src/fiber.h | 80 +++++++++++++++++++---------------------------------- > src/fiber_channel.c | 31 ++++++--------------- > src/lua/fiber.c | 19 ++++++------- -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov