From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Sat, 9 Jun 2018 15:34:17 +0300 From: Vladimir Davydov Subject: Re: [tarantool-patches] [PATCH v2 0/2] Create bigrefs for tuples Message-ID: <20180609123417.3es6j42p4kel36xr@esperanza> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: To: imeevma@tarantool.org Cc: tarantool-patches@freelists.org List-ID: [ Below is a comment regarding our review process. Please take it into account in future. No need to resend anything now. ] Apparently, it's not v2 anymore, but rather v6. Please bump the version every time you submit a new patch version. Also, according to our review guideline, you need to: - Say a few words about the patch set in the cover letter. - Add hyperlinks to the GitHub issue and branch corresponding to your patch set. - Write a brief change log that outlines what have changed since the version submitted last time. You can read the guideline here: https://tarantool.io/en/doc/1.9/dev_guide/developer_guidelines.html#how-to-submit-a-patch-for-review Here's an example of a good cover letter: https://www.freelists.org/post/tarantool-patches/PATCH-v2-05-vinyl-multipart-bloom-filter On Sat, Jun 09, 2018 at 02:49:03PM +0300, imeevma@tarantool.org wrote: > Mergen Imeev (1): > box: create bigrefs for tuples > > Vladislav Shpilevoy (1): > tuple: introduce bigref hints > > src/box/box.cc | 20 ++--- > src/box/errcode.h | 2 +- > src/box/index.cc | 20 ++--- > src/box/lua/tuple.c | 5 +- > src/box/port.c | 8 +- > src/box/tuple.c | 182 ++++++++++++++++++++++++++++++++++++++++-- > src/box/tuple.h | 105 +++++++++--------------- > src/box/vinyl.c | 38 ++++----- > test/box/misc.result | 39 +++++---- > test/box/select.result | 43 ++++++++-- > test/box/select.test.lua | 21 ++++- > test/unit/CMakeLists.txt | 3 + > test/unit/tuple_bigref.c | 174 ++++++++++++++++++++++++++++++++++++++++ > test/unit/tuple_bigref.result | 6 ++ > 14 files changed, 510 insertions(+), 156 deletions(-) > create mode 100644 test/unit/tuple_bigref.c > create mode 100644 test/unit/tuple_bigref.result