From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kostja@tarantool.org>
Date: Fri, 8 Jun 2018 16:15:24 +0300
From: Konstantin Osipov <kostja@tarantool.org>
Subject: Re: [RFC PATCH 06/12] box: refactor hot standby recovery
Message-ID: <20180608131524.GD10854@chai>
References: <cover.1528305232.git.vdavydov.dev@gmail.com>
 <27aabda1063798f83ca4415c01001838bded35c4.1528305232.git.vdavydov.dev@gmail.com>
 <20180608044045.GO6866@chai>
 <20180608064302.2xmkbnwwaovy5kg6@esperanza>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180608064302.2xmkbnwwaovy5kg6@esperanza>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

* Vladimir Davydov <vdavydov.dev@gmail.com> [18/06/08 11:28]:
> No, it doesn't. See, even though it removes recover_remaining_wals()
> from recovery_finalize(), it makes hot_standby_f() call it before
> returning, so that we will rescan the xlog dir just before leaving
> hot standby mode:

This is quite tricky. And I don't see why you need to do it this
way - why not add recover_remaining_wals to box_init instead,
where it will be more visible.

> > @@ -490,6 +486,7 @@ hot_standby_f(va_list ap)
> >  
> >  		subscription.events = 0;
> >  	}
> > +	recover_remaining_wals(r, stream, NULL, true);
> >  	return 0;
> >  }

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov