From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 8 Jun 2018 07:40:45 +0300 From: Konstantin Osipov Subject: Re: [RFC PATCH 06/12] box: refactor hot standby recovery Message-ID: <20180608044045.GO6866@chai> References: <27aabda1063798f83ca4415c01001838bded35c4.1528305232.git.vdavydov.dev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <27aabda1063798f83ca4415c01001838bded35c4.1528305232.git.vdavydov.dev@gmail.com> To: Vladimir Davydov Cc: tarantool-patches@freelists.org List-ID: * Vladimir Davydov [18/06/06 20:45]: > Currently, we start a hot standby fiber even if not in hot standby mode > (see recovery_follow_local). And we scan the wal directory twice - first > time in recovery_follow_local(), second time in recovery_finalize(). > Let's factor out recover_remaining_wals() from those functions and call > it explicitly. And let's start call follow_local() and stop_local() only > if in hot standby mode. In hot standby mode, we need to make sure we scan all the WALs at least once after we acquired a path lock. As far as I understand this patch, it removes this property. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov