From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 4D72825F1D for ; Thu, 7 Jun 2018 23:52:28 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id y3qkCZRZo3G0 for ; Thu, 7 Jun 2018 23:52:28 -0400 (EDT) Received: from smtp58.i.mail.ru (smtp58.i.mail.ru [217.69.128.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 0BBF625D42 for ; Thu, 7 Jun 2018 23:52:27 -0400 (EDT) Date: Fri, 8 Jun 2018 06:52:24 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH v3 4/4] netbox: introduce iterable future objects Message-ID: <20180608035224.GF6866@chai> References: <9044b6d5e206cf3f9da67a1a8f32c070b8db55c4.1527886471.git.v.shpilevoy@tarantool.org> <20180607125638.GB30262@chai> <9354d48e-78b5-9906-6f0c-057ce69b2389@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9354d48e-78b5-9906-6f0c-057ce69b2389@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Vladislav Shpilevoy Cc: tarantool-patches@freelists.org * Vladislav Shpilevoy [18/06/07 23:59]: > On 07/06/2018 15:56, Konstantin Osipov wrote: > > * Vladislav Shpilevoy [18/06/02 02:09]: > > > Netbox has two major ways to execute a request: sync and async. > > > During execution of any a server can send multiplie responses via > > > IPROTO_CHUNK. And the execution ways differ in how to handle the > > > chunks (called messages or pushes). > > > > Please don't use asserts. They are hell to debug. Please use > > tap suite if you need to check things, or simple output the result > > you expect. > > I have removed assertions and use output checking. > > > > > The patch itself looks good to me. Did you send a message to > > docbot about the new API? > > > > Yes, I have already created docbot request. But I do not agree with > the API, when push by default is taken from session.sync. If you want > make the sync be optional, we must either > > * make it mandatory, fix box.session.sync()/introduce fiber_sync()/something > else, then allow to omit sync; > > Or > > * fix sync and then commit box.session.push with optional sync. Or with no > sync, and allow it when somebody asks. Vlad, thank you for voicing your disagreement. Please prepare a patch which makes box.session.push() second argument optional. Thanks. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov