From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 7 Jun 2018 17:02:54 +0300 From: Konstantin Osipov Subject: Re: [PATCH v3 0/3] Allow to build indexes for vinyl spaces Message-ID: <20180607140254.GA27029@chai> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: To: Vladimir Davydov Cc: tarantool-patches@freelists.org List-ID: * Vladimir Davydov [18/06/07 14:27]: I pushed this patch set. Vlad, if you have any comment re the last patch in the stack, please write them here. I believe we need to replace region_alloc with a new allocator rather than wasting time on each individual case when copying memory could be avoided. Let's see how the community likes this feature. > This patch set implements the ability to build secondary indexes for > non-empty vinyl spaces. For implementation details, see patch 3. > > https://github.com/tarantool/tarantool/issues/1653 > https://github.com/tarantool/tarantool/commits/vy-allow-to-build-secondary-indexes > > - When building a new index, use original tuple LSNs instead > of max LSN to the time. This is a very good fix. We only need to get rid of vylog to make the whole thing perfect, and now we are a little closer to knowing how to do it. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov