From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 52E8724D01
	for <tarantool-patches@freelists.org>; Thu,  7 Jun 2018 08:56:41 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 3PuJvSNDe_xK for <tarantool-patches@freelists.org>;
	Thu,  7 Jun 2018 08:56:41 -0400 (EDT)
Received: from smtp36.i.mail.ru (smtp36.i.mail.ru [94.100.177.96])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 0AA2724CB9
	for <tarantool-patches@freelists.org>; Thu,  7 Jun 2018 08:56:40 -0400 (EDT)
Date: Thu, 7 Jun 2018 15:56:38 +0300
From: Konstantin Osipov <kostja@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v3 4/4] netbox: introduce iterable future objects
Message-ID: <20180607125638.GB30262@chai>
References: <cover.1527886471.git.v.shpilevoy@tarantool.org>
 <9044b6d5e206cf3f9da67a1a8f32c070b8db55c4.1527886471.git.v.shpilevoy@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <9044b6d5e206cf3f9da67a1a8f32c070b8db55c4.1527886471.git.v.shpilevoy@tarantool.org>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@freelists.org

* Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [18/06/02 02:09]:
> Netbox has two major ways to execute a request: sync and async.
> During execution of any a server can send multiplie responses via
> IPROTO_CHUNK. And the execution ways differ in how to handle the
> chunks (called messages or pushes).

Please don't use asserts. They are hell to debug. Please use
tap suite if you need to check things, or simple output the result
you expect.

The patch itself looks good to me. Did you send a message to
docbot about the new API?

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov