From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 7 Jun 2018 08:41:28 +0300 From: Konstantin Osipov Subject: Re: [PATCH v2 4/8] vinyl: bump mem version after committing statement Message-ID: <20180607054128.GA29856@chai> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: To: Vladimir Davydov Cc: tarantool-patches@freelists.org List-ID: * Vladimir Davydov [18/05/28 07:49]: > Since commit 1e1c1fdbeddb ("vinyl: make read iterator always return > newest tuple version") vinyl read iterator guarantees that any tuple it > returns is the newest version in the iterator read view. However, if we > don't bump mem version after assigning LSN to a mem statement, a read > iterator using committed_read_view might not see it and return a stale > tuple. Currently, there's no code that relies on this iterator feature, > but we will need it for building new indexes. Without this patch, build > (introduced later in the series) might return inconsistent results. Pushed. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov