From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 31 May 2018 10:48:06 +0300 From: Vladimir Davydov Subject: Re: [PATCH 2/2] box: allow to specify the checkpoint to backup Message-ID: <20180531074806.vuwx6qknzdcpfnya@esperanza> References: <09748147b73af6d2d828874f5178444a08dcfb94.1527669266.git.vdavydov.dev@gmail.com> <20180530190805.GG18850@atlas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180530190805.GG18850@atlas> To: Konstantin Osipov Cc: tarantool-patches@freelists.org List-ID: On Wed, May 30, 2018 at 10:08:05PM +0300, Konstantin Osipov wrote: > * Vladimir Davydov [18/05/30 11:45]: > > Even though we store last box.cfg.checkpoint_count checkpoints, we can > > only restore to the last one, because the backup API only allows to > > backup the last checkpoint. This patch adds an optional argument to > > box.backup.start() which specifies the index of the checkpoint to > > backup. If it is omitted or is 0, box.backup.start() will return files > > corresponding to the last checkpoint. If it is 1, it will back the > > previous checkpoint, and so on. > > > > Closes #3410 > > Please open a documentation request. > > The test case fails on my system, most likely once again because I > use symlinks. Looks like this is actually a bug in garbage collection, which was introduced by my commit 35db70fac55c ("vinyl: remove runs not referenced by any checkpoint immediately"). I opened a ticket: https://github.com/tarantool/tarantool/issues/3437 It shouldn't be difficult to fix. I guess we should assign it to 1.9.