From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 6EE06258DE for ; Wed, 30 May 2018 04:35:14 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Mb4uNRA3Dpu7 for ; Wed, 30 May 2018 04:35:14 -0400 (EDT) Received: from smtp20.mail.ru (smtp20.mail.ru [94.100.179.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 2B277258B3 for ; Wed, 30 May 2018 04:35:13 -0400 (EDT) Date: Wed, 30 May 2018 11:35:12 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH 1/1] sql: IS is only applicable when dealing with NULL Message-ID: <20180530083511.6sk32kf66b6esft5@tarantool.org> References: <1526642787.218420559@f261.i.mail.ru> <10ce4eb3-e380-3007-8811-78d6f4517e1b@tarantool.org> <1526659840.883327245@f345.i.mail.ru> <7283762e-ce01-fd16-a50b-26b6730711cc@tarantool.org> <6984db02-b1d1-942b-6a04-8684fcbc87ae@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Vladislav Shpilevoy Cc: tarantool-patches@freelists.org, Imeev Mergen On 24 мая 22:46, Vladislav Shpilevoy wrote: > Thanks for the fixes! I force pushed my review fixes. Now LGTM. > > Kirill, please, do something. I've committed your changes to 2.0 branch. Mergen, could you pls in future obey SOP rules on brancgh naming? -- Regards, Kirill Yukhin