From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id EA63924C99 for ; Thu, 24 May 2018 10:23:22 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AyVzOIhrGVqC for ; Thu, 24 May 2018 10:23:22 -0400 (EDT) Received: from smtp54.i.mail.ru (smtp54.i.mail.ru [217.69.128.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id A34BF24C98 for ; Thu, 24 May 2018 10:23:21 -0400 (EDT) Date: Thu, 24 May 2018 17:23:18 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH] sql: allow any space symbols to be a white space Message-ID: <20180524142318.beimzmewm5zyd2vy@tarantool.org> References: <20180523051500.3fx5uoetyzsjkwp5@tarantool.org> <20180523055408.6axbc53uucslcu4h@tarantool.org> <20180523140550.qqegk7wzv7ycc76m@tarantool.org> <7cbf79d0-8242-4079-8641-1635a45e863d@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7cbf79d0-8242-4079-8641-1635a45e863d@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Vladislav Shpilevoy Cc: tarantool-patches@freelists.org Hello, On 24 мая 14:09, Vladislav Shpilevoy wrote: > LGTM. Thanks, I've committed the patch into 2.0 branch. -- Regards, Kirill Yukhin > > On 23/05/2018 17:05, Kirill Yukhin wrote: > > Hi Vlad, > > Thanks for review! My comments inlined. > > > > On 23 мая 13:29, Vladislav Shpilevoy wrote: > > > Hello. Thanks for the fixes! I see, that you changed branch to > > > kyukhin/gh-2371-utf8-spaces-check, right? > > Nope, branch is the same. This one was for Travis checking. > > Original branch contains updated patch, which in turn contains > > update for CMakeLists.txt. I've removed this temporary branch.