From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 65407233D2 for ; Wed, 23 May 2018 14:15:31 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uKZvS6HBwUgT for ; Wed, 23 May 2018 14:15:31 -0400 (EDT) Received: from smtp38.i.mail.ru (smtp38.i.mail.ru [94.100.177.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 218B722704 for ; Wed, 23 May 2018 14:15:30 -0400 (EDT) Date: Wed, 23 May 2018 21:15:28 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH v7 6/7] sql: export funcs defined on Expr, ExprList to sql.h Message-ID: <20180523181528.GH4266@atlas> References: <26d7bf8070e9e573eb61897c34bf027a52eb8d66.1527084287.git.kshcherbatov@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <26d7bf8070e9e573eb61897c34bf027a52eb8d66.1527084287.git.kshcherbatov@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: v.shpilevoy@tarantool.org, Kirill Shcherbatov * Kirill Shcherbatov [18/05/23 20:33]: > As we would like work with check in server, we need to export > - sqlite3ExprListAppend as sql_expr_list_append > - sqlite3ExprListDelete as sql_expr_list_delete > - sqlite3ExprListDup as sql_expr_list_dup. I don't understand why we need to use internal parser API calls in the server. It seems all the server should need to know is how to invoke the parser with a string fragment, and how to convert the resulting AST to vdbe, and then how to execute the vdbe/free the resources. Perhaps there should be a method to reset the vdbe for subsequent execution. Why do we need to use low-level parser calls in the server? -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov