From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kostja@tarantool.org>
Date: Wed, 23 May 2018 20:56:55 +0300
From: Konstantin Osipov <kostja@tarantool.org>
Subject: Re: [PATCH v2 1/2] memtx: rework background garbage collection
 procedure
Message-ID: <20180523175655.GD4266@atlas>
References: <cover.1527009486.git.vdavydov.dev@gmail.com>
 <e58a936bd33f1c632b2975fdd887453a040915af.1527009486.git.vdavydov.dev@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e58a936bd33f1c632b2975fdd887453a040915af.1527009486.git.vdavydov.dev@gmail.com>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

* Vladimir Davydov <vdavydov.dev@gmail.com> [18/05/22 20:29]:
>  {
> -	index_def_delete(index->def);
> +	/*
> +	 * Free index_def after destroying the index as
> +	 * engine might still need it.
> +	 */

For what? 

> +	struct index_def *def = index->def;
>  	index->vtab->destroy(index);
> +	index_def_delete(def);
>  }
  
OK to push.


-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov