From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id C1AA924764 for ; Wed, 23 May 2018 13:46:51 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id N_q3xYRarXRB for ; Wed, 23 May 2018 13:46:51 -0400 (EDT) Received: from smtp57.i.mail.ru (smtp57.i.mail.ru [217.69.128.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 3900C24760 for ; Wed, 23 May 2018 13:46:51 -0400 (EDT) Date: Wed, 23 May 2018 20:46:48 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH v7 1/7] sql: remove parser construct, destruct to sql.h Message-ID: <20180523174648.GB4266@atlas> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: v.shpilevoy@tarantool.org, Kirill Shcherbatov * Kirill Shcherbatov [18/05/23 20:33]: > Moved sql_parser_construct and sql_parser_destruct to sql.h to > use them not only in DDL. > Removed SELECTTRACE_ENABLED macro with conditional fields from > struct Parse to prevent different object sizes across the project. > > Part of #3272. LGTM. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov