From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id A0CC7226A0 for ; Tue, 22 May 2018 03:01:28 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RzaRXoE54MEY for ; Tue, 22 May 2018 03:01:28 -0400 (EDT) Received: from smtp21.mail.ru (smtp21.mail.ru [94.100.179.250]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 537C7203E8 for ; Tue, 22 May 2018 03:01:28 -0400 (EDT) Date: Tue, 22 May 2018 10:01:26 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH v2 1/1] sql: COLLATE after LIMIT throws an error Message-ID: <20180522070126.7clkpwz43e4yzxc7@tarantool.org> References: <13ccf5856ab21d72c71a3fc5f65739871d824b40.1526913411.git.imeevma@tarantool.org> <1526915797.481599602@f468.i.mail.ru> <1526921455.373334107@f455.i.mail.ru> <77671f74-9ee6-e05b-f317-41cf9fab7b02@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <77671f74-9ee6-e05b-f317-41cf9fab7b02@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Vladislav Shpilevoy Cc: tarantool-patches@freelists.org, =?utf-8?B?0JzQtdGA0LPQtdC9INCY0LzQtdC10LI=?= Hello Mergen, Vlad, On 21 мая 21:26, Vladislav Shpilevoy wrote: > LGTM. Kirill, can you please take a look? I've checked your patch into 2.0 branch. In future, could you please follow SOP policies? For details, please take a look ar chaptert `Submitting a patch`. -- Regards, Kirill Yukhin