From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id C9E9222769
	for <tarantool-patches@freelists.org>; Tue, 22 May 2018 02:56:30 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id RireKHt6hxTh for <tarantool-patches@freelists.org>;
	Tue, 22 May 2018 02:56:30 -0400 (EDT)
Received: from smtp51.i.mail.ru (smtp51.i.mail.ru [94.100.177.111])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 04860203E8
	for <tarantool-patches@freelists.org>; Tue, 22 May 2018 02:56:29 -0400 (EDT)
Date: Tue, 22 May 2018 09:56:26 +0300
From: Kirill Yukhin <kyukhin@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH 1/1] sql: fix out of time auto
 commit mode detection
Message-ID: <20180522065626.xln422smjfeedrvm@tarantool.org>
References: <0fecccaea1baa046854e58e9ebffeb207103e7c3.1526938154.git.v.shpilevoy@tarantool.org>
 <1526939115.721063905@f481.i.mail.ru>
 <72eccb80-83ec-bcda-56b0-8abe69f0cccb@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <72eccb80-83ec-bcda-56b0-8abe69f0cccb@tarantool.org>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org
Cc: Nikita Pettik <korablev@tarantool.org>

Hello Vlad,
On 22 мая 00:46, Vladislav Shpilevoy wrote:
> Hello. Thanks for review!
> 
> On 22/05/2018 00:45, Nikita Pettik wrote:
> >     + * Once per execution time prepare the programm: detect
> > 
> > Nitpicking: 'program'.
> 
> @@ -5352,7 +5352,7 @@ case OP_Init: {          /* jump */
>         assert(pOp->p4.z==0 || strncmp(pOp->p4.z, "-" "- ", 3)==0);
>         assert(pOp==p->aOp);  /* Always instruction 0 */
>         /*
> -        * Once per execution time prepare the programm: detect
> +        * Once per execution time prepare the program: detect
>          * autocommit, create SQL specific transaction things. To
> > 
> > LGTM.

I've checked you patch into 2.0 branch.
In future, could you pls name your branches according to SOP?
Please, see chapter `Submitting a patch` for details.

> > -- 
> > Nikita Pettik

--
Regards, Kirill Yukhin