From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 21 May 2018 21:50:52 +0300 From: Konstantin Osipov Subject: Re: [PATCH 1/2] replication: do not delete relay on applier disconnect Message-ID: <20180521185052.GA8516@atlas> References: <9fa887ca5a8ea2b9d496a7bfd0d4c7a83da26ac8.1526921933.git.k.belyavskiy@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9fa887ca5a8ea2b9d496a7bfd0d4c7a83da26ac8.1526921933.git.k.belyavskiy@tarantool.org> To: Konstantin Belyavskiy Cc: tarantool-patches@freelists.org, vdavydov@tarantool.org, georgy@tarantool.org List-ID: * Konstantin Belyavskiy [18/05/21 20:11]: Both patches look good to me, but since you're deleting relay->exiting, I would clear the WAL watcher before fiber_join(&reader), to shorten the gap during which we try to send unnecessary events to the client. . -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov