From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 375ED25354 for ; Thu, 17 May 2018 12:03:54 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id W5ABr0_WBjaL for ; Thu, 17 May 2018 12:03:54 -0400 (EDT) Received: from smtp20.mail.ru (smtp20.mail.ru [94.100.179.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id E2C8125312 for ; Thu, 17 May 2018 12:03:53 -0400 (EDT) Date: Thu, 17 May 2018 19:03:51 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH] sql: remove temporary box_iterator_key_def Message-ID: <20180517160351.i36etvuizc2x7sfs@tarantool.org> References: <98d8572affd09ca99e92f29e90165ca29f664847.1526564450.git.kyukhin@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Vladislav Shpilevoy Cc: tarantool-patches@freelists.org Hello Vlad, On 17 мая 18:05, Vladislav Shpilevoy wrote: > Hello. Thanks for the patch! > > On 17/05/2018 16:41, Kirill Yukhin wrote: > > It is possible to extract key_def from iterator directly > > in SQL FE. So, no need in any temporary API hacks anymore. > > The patch removes this API function and replaces its calls > > w/ direct field access in SQL FE. > > > > Closes #2425 > > --- > > 1. Please, post branch and issue links here. Branch: https://github.com/tarantool/tarantool/tree/kyukhin/gh-2425-remove-box_iterator_key_def Issue: https://github.com/tarantool/tarantool/issues/2425 > 2. I can not find any branch with 2425 in name. I forgot to push it to GH. Done. > The patch LGTM. I'll commit it to 2.0 branch, thanks! -- Regards, Kirill Yukhin