From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id DF944251F8 for ; Fri, 11 May 2018 03:17:45 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id shkB2AegkR6C for ; Fri, 11 May 2018 03:17:45 -0400 (EDT) Received: from smtp33.i.mail.ru (smtp33.i.mail.ru [94.100.177.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 510D4251F1 for ; Fri, 11 May 2018 03:17:45 -0400 (EDT) Date: Fri, 11 May 2018 10:17:42 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH 0/4] Rework SQL transaction processing Message-ID: <20180511071742.xxh4kgze3rqznrt4@tarantool.org> References: <18ab40f4-4357-f2bd-9280-1069f936995b@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <18ab40f4-4357-f2bd-9280-1069f936995b@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: Nikita Pettik Hello Nikita, Vlad, On 07 мая 16:31, Vladislav Shpilevoy wrote: > Hello. Thanks for review fixes! The whole patchset LGTM now. > > On 03/05/2018 21:49, Nikita Pettik wrote: > > Branch: https://github.com/tarantool/tarantool/tree/np/rework-sql-transactions > > Issue: > > https://github.com/tarantool/tarantool/issues/3237 > > https://github.com/tarantool/tarantool/issues/3313 > > https://github.com/tarantool/tarantool/issues/3379 The patch set fails testing: [026] sql/transitive-transactions.test.lua [ fail ] [026] [026] Test failed! Result content mismatch: [033] sql/drop-table.test.lua [ pass ] [026] --- sql/transitive-transactions.result Fri May 11 10:15:28 2018 [026] +++ sql/transitive-transactions.reject Fri May 11 10:15:53 2018 [026] @@ -107,19 +107,20 @@ [026] box.sql.execute('PRAGMA defer_foreign_keys = 1;') [026] fk_defer(); [026] --- [026] +- error: 'Operation is not permitted when there is an active transaction ' [026] ... [026] box.space.CHILD:select(); [026] --- [026] -- - [1, 2] [026] +- [] [026] ... -- Regards, Kirill Yukhin