From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 3F10424CBE for ; Fri, 11 May 2018 02:01:23 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uvtAXwEyNILO for ; Fri, 11 May 2018 02:01:23 -0400 (EDT) Received: from smtp14.mail.ru (smtp14.mail.ru [94.100.181.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id EF92224CBC for ; Fri, 11 May 2018 02:01:22 -0400 (EDT) Date: Fri, 11 May 2018 09:01:16 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH] sql: allow ON CONFLICT REPLACE only for PK index Message-ID: <20180511060116.pdegorozkbvjccwu@tarantool.org> References: <20180422073719.13245-1-niatshin@tarantool.org> <8920AA01-8BCD-40F3-B6E3-908C5D9A99F6@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8920AA01-8BCD-40F3-B6E3-908C5D9A99F6@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: "n.pettik" Cc: tarantool-patches@freelists.org Hello Bulat, Nikita, On 04 мая 02:39, n.pettik wrote: > I am OK with this patch. > I have fixed a few minor codestyle violations and > rebased to fresh 2.0 The patch makes sql/on-conflict test fail. Could you pls fix it. -- Regards, Kirill Yukhin