From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id AB5AF24EB6 for ; Fri, 11 May 2018 01:28:05 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wTT5O9MC6gQ5 for ; Fri, 11 May 2018 01:28:05 -0400 (EDT) Received: from smtp41.i.mail.ru (smtp41.i.mail.ru [94.100.177.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id EF44524EB5 for ; Fri, 11 May 2018 01:28:04 -0400 (EDT) Date: Fri, 11 May 2018 08:28:02 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH] sql: Fixes op-codes' generation for skip-scan Message-ID: <20180511052802.ogws5u3c5qqznuki@tarantool.org> References: <20180427100613.94160-1-ivan.koptelov@tarantool.org> <1525421405.73000074@f511.i.mail.ru> <1525689755.121433755@f473.i.mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: "n.pettik" Cc: tarantool-patches@freelists.org, Ivan Koptelov Hi Ivan, Nikita, On 08 мая 19:59, n.pettik wrote: > > > Fix code style violation. Add types. > > > > -- > > Ivan Koptelov > > <0001-sql-fixes-op-codes-generation-for-skip-scan.patch> > > Thanks. Now LGTM. I've checked the patch into 2.0 -- Regards, Kirill Yukhin