From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id BCC11232F8 for ; Tue, 8 May 2018 16:22:05 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6m9-rK720Mbj for ; Tue, 8 May 2018 16:22:05 -0400 (EDT) Received: from smtp60.i.mail.ru (smtp60.i.mail.ru [217.69.128.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 7BD0E22F0D for ; Tue, 8 May 2018 16:22:05 -0400 (EDT) Date: Tue, 8 May 2018 23:22:02 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 3/3] rope: make rope library be C template using macros Message-ID: <20180508202202.GC26928@atlas> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Vladislav Shpilevoy Cc: tarantool-patches@freelists.org * Vladislav Shpilevoy [18/04/28 08:50]: > Rope library stores alloc, split and free functions by pointer, > that is a huge slog at performance. There is no reason, why the > rope library can not become a template. I believe you still should keep some "slowpath" code in rope.c - smaller binary footprint is usually faster. I'm not sure though it'd be easy to extract. In any case I'd wait with pushing this patch until we see the rest. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov